On Mon, Jul 08, 2019 at 02:11:34PM +0800, Hao Wu wrote: > Thank you for your quick response! I work on greenplum, and I didn't see > this folder(src/test/ssl/ssl) before. > I will add more certificates to test and resend again.
Not having duplicates would be nice. > Do you have any suggestion about the missing PGDATA? Since the test needs > to configure postgresql.conf, maybe there are other ways to determine this > environment. +REGRESS = sslinfo +REGRESS_OPT = --temp-config=$(top_srcdir)/contrib/sslinfo/sslinfo.conf When it comes to custom configuration files in the regression tests, you should always have NO_INSTALLCHECK = 1 in the Makefile because there is no guarantee that that the running server will have the configuration you want when running an installcheck. +echo "preparing CRTs and KEYs" +cp -f data/root.crt $PGDATA/ +cp -f data/server.crt $PGDATA/ +cp -f data/server.key $PGDATA/ +chmod 400 $PGDATA/server.key +chmod 644 $PGDATA/server.crt +chmod 644 $PGDATA/root.crt Using a TAP test here would be more adapted. Another idea would be to add that directly into src/test/ssl/ and enforce the installation of with EXTRA_INSTALL when running the tests. +-- start_ignore +\! bash config.bash clean +\! pg_ctl restart 2>&1 >/dev/null +-- end_ignore Please, no... -- Michael
signature.asc
Description: PGP signature
