On Wed, Jun 26, 2019 at 2:46 AM Ildar Musin <il...@adjust.com> wrote: > Attached is a simple patch that uses subxid instead of top-level xid > in ReorderBufferAddNewTupleCids() call. It seems to fix the bug, but > i'm not sure that this is a valid change. Can someone please verify it > or maybe suggest a better solution for the issue?
Hello Ildar, I hope someone more familiar with this code than me can comment, but while going through the Commitfest CI results I saw this segfault with your patch: https://travis-ci.org/postgresql-cfbot/postgresql/builds/555184304 At a glance, HistoricSnapshotGetTupleCids() returned NULL in HeapTupleSatisfiesHistoricMVCC(), so ResolveCminCmaxDuringDecoding() blew up. -- Thomas Munro https://enterprisedb.com
