Hi Nikolay,

I have had a crack at re-basing the current patch against 12b2, but I didn’t 
trivially succeed.

It’s probably more my bodged fixing of the rejections than a fundamental 
problem. But I now get compile fails in — and seems like only — vacuum.c.

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -g -O2 
-I../../../src/include  -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk
    -c -o vacuum.o vacuum.c
vacuum.c:1761:20: error: expected expression
                        ((StdRdOptions *) 
onerel->rd_options)->vacuum_index_cleanup)
                                        ^
vacuum.c:1761:6: error: use of undeclared identifier 'StdRdOptions'
                        ((StdRdOptions *) 
onerel->rd_options)->vacuum_index_cleanup)
                          ^
vacuum.c:1771:20: error: expected expression
                        ((StdRdOptions *) onerel->rd_options)->vacuum_truncate)
                                        ^
vacuum.c:1771:6: error: use of undeclared identifier 'StdRdOptions'
                        ((StdRdOptions *) onerel->rd_options)->vacuum_truncate)
                          ^
4 errors generated.

I see that your patch removed that particular type, so I guess that feature in 
vacuum.c has been added in the meantime.

Would you have a more recent patch?

For what it is worth, I had a play at getting it to work, and only made things 
much worse!

denty.

> On 1 Jul 2019, at 12:52, Thomas Munro <thomas.mu...@gmail.com> wrote:
> 
> On Mon, Apr 1, 2019 at 4:36 AM Nikolay Shaplov <dh...@nataraj.su> wrote:
>> В письме от понедельник, 18 марта 2019 г. 3:03:04 MSK пользователь Iwata, Aya
>> написал:
>>> This patch does not apply.
>> Oh... Sorry... here goes new version
> 
> Hi Nikolay,
> 
> Could we please have a new rebase?
> 
> Thanks,
> 
> -- 
> Thomas Munro
> https://enterprisedb.com

Reply via email to