Hi all, We have been using RAND_OpenSSL(), a function new as of OpenSSL 1.1.0 in pgcrypto until fe0a0b5 which has removed the last traces of the function in the tree. We still have a configure check for it and the related compilation flag in pg_config.h.in, and both are now useless.
Any objections to the cleanup done in the attached patch? Thanks, -- Michael
diff --git a/configure b/configure index 8d47071e4a..9860b0b95d 100755 --- a/configure +++ b/configure @@ -12146,7 +12146,7 @@ done # defines OPENSSL_VERSION_NUMBER to claim version 2.0.0, even though it # doesn't have these OpenSSL 1.1.0 functions. So check for individual # functions. - for ac_func in OPENSSL_init_ssl BIO_get_data BIO_meth_new ASN1_STRING_get0_data RAND_OpenSSL + for ac_func in OPENSSL_init_ssl BIO_get_data BIO_meth_new ASN1_STRING_get0_data do : as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh` ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var" diff --git a/configure.in b/configure.in index 74938d4190..efc33d4775 100644 --- a/configure.in +++ b/configure.in @@ -1212,7 +1212,7 @@ if test "$with_openssl" = yes ; then # defines OPENSSL_VERSION_NUMBER to claim version 2.0.0, even though it # doesn't have these OpenSSL 1.1.0 functions. So check for individual # functions. - AC_CHECK_FUNCS([OPENSSL_init_ssl BIO_get_data BIO_meth_new ASN1_STRING_get0_data RAND_OpenSSL]) + AC_CHECK_FUNCS([OPENSSL_init_ssl BIO_get_data BIO_meth_new ASN1_STRING_get0_data]) # OpenSSL versions before 1.1.0 required setting callback functions, for # thread-safety. In 1.1.0, it's no longer required, and CRYPTO_lock() # function was removed. diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in index 6cd4cfed0a..512213aa32 100644 --- a/src/include/pg_config.h.in +++ b/src/include/pg_config.h.in @@ -464,9 +464,6 @@ /* Define to 1 if you have the `random' function. */ #undef HAVE_RANDOM -/* Define to 1 if you have the `RAND_OpenSSL' function. */ -#undef HAVE_RAND_OPENSSL - /* Define to 1 if you have the <readline.h> header file. */ #undef HAVE_READLINE_H
signature.asc
Description: PGP signature
