On 6/23/19 10:27 PM, Michael Paquier wrote: > On Sun, Jun 23, 2019 at 06:15:06PM -0400, Andrew Dunstan wrote: >> Alvaro pointed out to me recently that the buildfarm client doesn't have >> any provision for running module tests like commit_ts and >> snapshot_too_old that use NO_INSTALLCHECK. On looking into this a bit >> more, I noticed that we also don't run any TAP tests in >> src/test/modules. I'm adding some code to the client to remedy both of >> these, and crake has been running it quite happily for a week or so. Are >> there any other holes of this nature that should be plugged? > src/test/kerberos/ and src/test/ldap/.
We already make provision for those. See PG_TEST_EXTRA in the config file > > contrib modules having TAP tests are actually able to run the tests. > Only an installcheck triggered from contrib/ happens at step > contrib-install-check-C, right? Yes, but I will add in support for the contrib TAP tests, thanks. > >> We'll need some MSVC build tools support for some of it. > This one is more complex. We don't actually track TAP_TESTS in > src/tools/msvc/ yet. Cough. We do have support for some TAP tests, I will make sure we can run all of them cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
