On 6/21/19 3:07 PM, Stephen Frost wrote: > When it comes to cases that fundamentally are one-off's and that we > don't think really deserve a proper DDL command, then I'd say we make > the extensions set the flag. At least then it's clear "hey, we had to > do something really grotty here, maybe don't copy this into your new > extension, or don't use this method." We should also un-set the flag > after.
I'd be leery of collateral damage from that to extension update scripts in extension releases currently in the wild. Maybe there should be a new extension control file setting needs_system_table_mods = (boolean) which means what it says if it's there, but if an ALTER EXTENSION UPDATE sees a control file that lacks the setting, assume true (with a warning?). Regards, -Chap