On Wed, Jun 12, 2019 at 7:52 AM Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > The current catalog files all do this: > > CATALOG(pg_aggregate,2600,AggregateRelationId) > { > ... > } FormData_pg_aggregate; > > typedef FormData_pg_aggregate *Form_pg_aggregate; > > The bottom part of this seems redundant. With the attached patch, we > can generate that automatically, so this becomes just > > CATALOG(pg_aggregate,2600,AggregateRelationId) > { > ... > };
Maybe the macro definition could be split across several lines instead of having one really long line? Are some compilers going to be sad about typedef struct x x; preceding any declaration or definition of struct x? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company