On 2019-May-23, Mark Dilger wrote: > On Thu, May 23, 2019 at 5:24 PM Michael Paquier <mich...@paquier.xyz> wrote:
> > Looking closer, this code is not new as of v12. We have that since > > e7b3349 which has introduced CREATE TABLE OF. Yeah, I was not quite understanding why it was being blamed on a commit that actually *removed* one other callsite that did the same thing. (I didn't actually realize at the time that this bug was there, mind.) > > Anyway, I think that assigning the result of list_delete_cell and > > adding an assertion like in the attached are saner things to do. Looks good to me. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
