On 2019-05-21 23:46, Tom Lane wrote: >> Would we want to also apply this to the back branches to avoid spurious >> conflicts? > I think we should hold off on any talk of that until we get some results > from Mark Dilger (or anyone else) on how much pain it would cause for > people carrying private patches.
In my experience, changes to function declarations in header files happen a lot in forks. So applying the pgindent change to backbranches would cause some trouble. On the other hand, it seems to me that patches that we backpatch between PostgreSQL branches should normally not touch function declarations in header files, since that would be an ABI break. So by not applying the pgindent change in backbranches we don't lose anything. And so it would be better to just leave things as they are. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
