On Mon, 13 May 2019 at 23:20, Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > In the latest PostgreSQL code, I could see that we are passing > CopyMultiInsertInfo structure to CopyMultiInsertInfoNextFreeSlot() although > it is not being used anywhere in that function. Could you please let me know > if it has been done intentionally or it is just an overlook that needs to be > corrected. AFAIU, CopyMultiInsertInfoNextFreeSlot() is just intended to > return the next free slot available in the multi insert buffer and we already > have that buffer stored in ResultRelInfo structure which is also being passed > to that function so not sure what could be the purpose of passing > CopyMultiInsertInfo structure as well. Please let me know if i am missing > something here. Thank you.
There's likely no good reason for that. The attached removes it. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
remove_unused_parameter_from_CopyMultiInsertInfoNextFreeSlot.patch
Description: Binary data
