On Wed, Apr 24, 2019 at 2:29 PM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > This is a really strange argument. You're saying that somebody thought > about it: "Hmm, well, I can remove this preprocessor symbol but then > trace_sort would no longer resemble a developer option. So I'm going to > leave the symbol alone". I don't think that's what happened. It seems > more likely to me that nobody has gone to the trouble of deciding that > the symbol is worth removing, let alone actually doing it.
It doesn't seem very important now. > If the instrumentation is good, and you seem to be saying that it is, I > think we should just remove the symbol and be done with it. Sounds like a plan. Do you want to take care of it, Joe? -- Peter Geoghegan