On Sat, Apr 6, 2019 at 6:16 AM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Pushed this.
Thank you! > > The mechanism of creating a new slot from the source, then later > advancing the LSN of the new slot using the updated values from the > source slot, seems quite clever. I reworded the comment that explained > how it is supposed to work; please double-check to ensure I got it > right. It looks good to me other than a typo pointed out by Petr. > > I renamed the opr_sanity-induced wrappers. I see no reason to get > very precise about what's what ... these functions are all identical. > Agreed. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
