> On Thu, Jan 31, 2019 at 12:24 PM Andres Freund <and...@anarazel.de> wrote: > > As nothing has happened since, I'm marking this as returned with > feedback.
This patch was on my radar for some time in the past and we've seen use cases where it could be pretty useful (probably even without the incremental sort patch). I would like to make some progress here and see if it's possible to continue it's development. I've attached the rebased version with a small changes, e.g. I've created a separate patch with group by reordering tests to make it easy to see what changes were introduced, and after some experiments removed part that seems to duplicate "group by" reordering to follow "order by". Also looks like it's possible to make these patches independent by having a base patch with the isolated group_keys_reorder_by_pathkeys (they're connected via n_preordered), but I haven't done this yet. I went through the thread to summarize the objections, that were mentioned so far. Most of them are related to the third patch in the series, where reordering based on "ndistincs" is implemented, and are about cost_sort (all the possible problems that could happen without proper cost estimation due to non uniform distribution, different comparison costs and so on) and figuring out how to limit number of possible combinations of pathkeys to compare. I haven't looked at the proposed backtracking approach, but taking into account that suggested patch for cost_sort [1] is RWF, I wonder what would be the best strategy to proceed? [1]: https://commitfest.postgresql.org/21/1706/
v11-0001-Add-tests-for-group-by-optimization.patch
Description: Binary data
v11-0002-Reorder-to-match-ORDER-BY-or-index.patch
Description: Binary data
v11-0003-Reorder-by-values-distribution.patch
Description: Binary data
