On Wednesday, March 27, 2019 1:43 PM, Christoph Berg <m...@debian.org> wrote:

> Re: Daniel Gustafsson 2019-03-26 
> pC-NMmh4vQLQP76YTwY4AuoD4OdNw9egikekyQpXFpgqmTlGjIZXOTd2W5RDZPpRski5N3ADRrLYgLk6QUuvmuT5fWC9acPAYyDU1AVxJcU=@yesql.se
>
> > 0003 - Make -B default to CWD and remove the exec_path check
> > Defaulting to CWD for the new bindir has the side effect that the default
> > sockdir is in the bin/ directory which may be less optimal.
>
> Hmm, I would have thought that the default for the new bindir is the
> directory where pg_upgrade is located, not the CWD, which is likely to
> be ~postgres or the like?

Yes, thinking on it that's obviously better.  The attached v2 repurposes the
find_my_exec() check to make the current directory of pg_upgrade the default
for new_cluster.bindir (the other two patches are left as they were).

cheers ./daniel

Attachment: 0001-Only-allow-upgrades-by-the-same-exact-version-new-v2.patch
Description: Binary data

Attachment: 0002-Check-all-used-executables-v2.patch
Description: Binary data

Attachment: 0003-Default-new-bindir-to-exec_path-v2.patch
Description: Binary data

Reply via email to