On 2019-Mar-29, Andres Freund wrote: > Hi, > > On 2019-03-29 12:02:18 -0300, Alvaro Herrera wrote: > > I just noticed that the CLUSTER calls index_build, which my patch > > modifies to include additional progress metrics; this means that during > > the index build phase, the metrics set by CLUSTER will be trashed by the > > ones my patch introduces. > > Yea, it really seems that the index build infrastructure needs to > support cooperating with the caller's progress reporting. For CLUSTER, > REINDEX, ALTER TABLE rewrites etc, they all would likely want to have > insight into the index build while also having their own progress.
So, CLUSTER and ALTER TABLE rewrites only do non-concurrent index builds; and REINDEX can reuse pretty much the same wait-for metrics columns as CIC. So I think it's okay if I move only the metrics that conflict for index_build. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
