On Thu, Mar 28, 2019 at 10:08 AM Andrey Borodin <x4...@yandex-team.ru> wrote: > >> Is this really needed? Isn't the ShareLock on the index sufficient? If so, > >> why? > > There may be concurrent inserts? In GiST they can reorder items on page. > > Looks like I've tried to cope with same problem twice: > v3 of the patch used AccessShareLock and many locks with incorrect order. > We could use one of possible solutions: either use ShareLock, or rewrite scan > to correct locking order. > But patches v4-v7 use both.
It definitely has to be one or the other. The combination makes no sense. -- Peter Geoghegan
