Patch has been committed, thanks.
On 2019-03-18 21:20, Fabien COELHO wrote:
> Minor remarks:
>
> In "xact.c", maybe I'd assign blockState in the else branch, instead of
> overriding it?
I think it was better the way it is, since logically the block state is
first set, then set again after the new transaction starts.
> About the static _SPI_{commit,rollback} functions: I'm fine with these
> functions, but I'm not sure about their name. Maybe
> _SPI_chainable_{commit,rollback} would be is clearer about their content?
I kept it as is, to mirror the names of the SQL commands.
> Doc looks clear to me. ISTM "chain" should be added as an index term?
Added, good idea.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
