Hi, Am Dienstag, den 19.03.2019, 09:04 +0900 schrieb Kyotaro HORIGUCHI: > At Mon, 18 Mar 2019 23:14:01 +0100 (CET), Fabien COELHO <coe...@cri.ensmp.fr> > wrote in <alpine.DEB.2.21.1903182311130.23282@lancre> > > >>> + /* we handle SIGUSR1 only, and toggle the value of show_progress > > >>> */ > > >>> + if (signum == SIGUSR1) > > >>> + show_progress = !show_progress; > > >> > > >> SIGUSR1 *toggles* progress. > > > > > > Not sure what you mean here, > > > > Probably it is meant to simplify the comment? > > Sorry. I meant that "it can be turned off and a perhaps-garbage > line is left alone after turning off. Don't we need to erase it?".
The current version prints a newline when it progress reporting is toggled off. Do you mean there is a hazard that this happens right when we are printing the progress, so end up with a partly garbage line? I don't think that'd be so bad to warrant further code complexitiy, after all, the user explicitly wanted the progress to stop. But maybe I am misunderstanding? Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz