On Thu, Mar 14, 2019 at 3:37 AM Masahiko Sawada <sawada.m...@gmail.com> wrote: > BTW your patch seems to not apply to the current HEAD cleanly and to > need to update the comment of vacuum().
Yeah, I omitted some hunks by being stupid with 'git'. Since you seem to like the approach, I put back the hunks I intended to have there, pulled in one change from your v2 that looked good, made one other tweak, and committed this. I think I like what I did with vacuum_open_relation a bit better than what you did; actually, I think it cannot be right to just pass 'params' when the current code is passing params->options & ~(VACOPT_VACUUM). My approach avoids that particular pitfall. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
