On 3/14/19 3:08 PM, Tom Lane wrote: > Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 3/14/19 12:41 AM, Tom Lane wrote: >>> So far, no other failures ... >> I have replicated this on my Msys2 test system. >> I assume it's a bug in the mingw math library. I think jacana is the >> only currently reporting mingw member :-( The MSVC members appear to be >> happy. >> I have several releases of the mingw64 toolsets installed on jacana - >> I'll try an earlier version to see if it makes a difference. > Yeah, it would be interesting to know whether it's consistent across > different mingw versions.
Tried with mingw64-gcc-5.4.0 (jacana is currently on 8.1.0). Same result. > > So far, though, jacana is still the only buildfarm animal that's having > trouble with those tests as of c015f853b. I want to wait another day or > so in hopes of getting more reports from stragglers. But assuming that > that stays true, I do not feel any need to try to work around jacana's > issues. We already have proof of two deficiencies in their > hyoerbolic-function code, and considering the tiny number of test cases > we've tried, it'd be folly to think there are only two. I don't want > to embark on a project to clean that up for the sake of one substandard > implementation. > > I feel therefore that what we should do (barring new evidence) is either > > 1. Remove all the inf/nan test cases for the hyoerbolic functions, on > the grounds that they're not really worth expending buildfarm cycles on > in the long run; or > > 2. Just comment out the one failing test, with a note about why. > > I haven't got a strong preference as to which. Thoughts? > > 2. would help us memorialize the problem. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
