On 2019-02-15 15:02, Alexey Bashtanov wrote: > Hello Anders and Peter, > > Thanks for your messages. > Please see the new patch version attached.
In my testing, I couldn't get this patch to do anything. Could you please share your testing steps? I did postgres -D data --log-parameters-on-error=on pgbench -i bench alter table pgbench_accounts alter column aid type smallint; pgbench -M extended -S -T 10 bench This will then error out on type overflows, but I don't see any parameters being logged: ERROR: value "62812" is out of range for type smallint STATEMENT: SELECT abalance FROM pgbench_accounts WHERE aid = $1; (In this case the error message contains the parameter value, so it's not a very practical case, but it should work, it seems.) Meanwhile, I have committed a patch that refactors the ParamListInfo initialization a bit, so you don't have to initialize hasTextValues in a bunch of places unrelated to your core code. So please rebase your patch on that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
