On Sat, Mar 9, 2019 at 7:48 PM Magnus Hagander <mag...@hagander.net> wrote: > > On Sat, Mar 9, 2019 at 12:33 AM Julien Rouhaud <rjuju...@gmail.com> wrote: >> >> Thanks! Our implementations are quite similar, so I'm fine with most >> of the changes :) I'm just not sure about having two distinct >> functions for reporting failures, given that there's only one caller >> for each. On the other hand it avoids to include miscadmin.h in >> bufpage.c. > > > Yeah, and it brings "cosistence" to at least the calling point(s) within > regular backends. > > >> >> That's just a detail, so I'm marking it (again) as ready for committer! > > > Thanks, and pushed :)
Thanks :)