On Fri, Mar 8, 2019 at 5:13 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > Few minor comments: .. > > 2. > + > + /* Transfer any VM files if we can trust their > contents. */ > if (vm_crashsafe_match) > > 3. Can we add a note about this in the Notes section of pg_upgrade > documentation [1]? > > This comment line doesn't seem to be related to this patch. If so, I > think we can avoid having any additional change which is not related > to the functionality of this patch. Feel free to submit it > separately, if you think it is an improvement. >
oops, I have messed up the above comments. The paragraph starting with "This comment line doesn't ..." is for comment number-2. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
