On 3/6/19 5:38 PM, Andrey Borodin wrote:
20 февр. 2019 г., в 17:06, Alexey Kondratov <a.kondra...@postgrespro.ru> 
написал(а):

The new patch is much smaller (less than 400 lines) and works as advertised.
There's a typo "retreive" there.

These lines look a little suspicious:
                char  postgres_exec_path[MAXPGPATH],
                                  postgres_cmd[MAXPGPATH],
                                  cmd_output[MAX_RESTORE_COMMAND];
Is it supposed to be any difference between MAXPGPATH and MAX_RESTORE_COMMAND?

Besides this, patch looks fine to me.

This patch appears to need attention from the author so I have marked it Waiting on Author.

Regards,
--
-David
da...@pgmasters.net

Reply via email to