On Sun, Feb 17, 2019 at 07:31:38PM +0100, Michael Banck wrote: > New patch attached.
- * src/bin/pg_verify_checksums/pg_verify_checksums.c + * src/bin/pg_checksums/pg_checksums.c That's lacking a rename, or this comment is incorrect. +#if PG_VERSION_NUM >= 100000 + StaticAssertStmt(sizeof(ControlFileData) <= PG_CONTROL_MAX_SAFE_SIZE, + "pg_control is too large for atomic disk writes"); +#endif This is compiled with only one version of the control file data, so you don't need that. Any reason why we don't refactor updateControlFile() into controldata_utils.c? This duplicates the code, at the exception of some details. -- Michael
signature.asc
Description: PGP signature
