"Imai, Yoshikazu" <imai.yoshik...@jp.fujitsu.com> writes: > ISTM the 0004 patch eventually removes these codes from multiple places > (set_append_rel_size and set_inherited_target_rel_sizes) so we might be > better to not be struggling here?
Yeah, Amit just pointed that out (and I'd not read 0004 before reacting to 0001). If the final state of the code isn't going to look like this, then whether the intermediate state is good style becomes far less important. Still, maybe it'd be better to drop the 0001 patch and absorb its effects into the later patch that makes that if-test go away entirely. regards, tom lane