Hi, Because I mistook something about how to reply to e-mails, my last reply is not reflected in the thread.
Response to Nagaura san's review point, I fixed all his review notes, except for pointing out about psql. Please see the attached updated patch. > 1) > It would be better making the log format the same as the server log format, I changed date style and added timezone. > 2) > It was difficult for me to understand the first line message in the log file. I changed the message as "The maximum size of this log is 3 Bytes, the parameter 'logminlevel' is set to level2 ". > 3) > Under the circumstance that the environment variables "PGLOGDIR" and > "PGLOGSIZE" are set correctly, the log file will also be created when the > user connect the server with "psql". > Does this follow the specification you have thought? > Is there any option to unset only in that session when you want to connect > with "psql"? By separating session using Tera Term or screen command, you can do what you want. So I didn't make the code complicated by implementing the option. > 4) > Your patch affects the behavior of PQtrace(). Thank you. I fixed. Regards, Aya Iwata
v6-0001-libpq-trace-log.patch
Description: v6-0001-libpq-trace-log.patch
