Amit-san Sorry for my late reply. I had another work to do.
On Fri, Feb 8, 2019 at 9:13 AM, Amit Langote wrote: > On 2019/02/08 13:44, Imai, Yoshikazu wrote: > > 3. > > 0001: line 1919-1920 > > > > - case CONSTRAINT_EXCLUSION_ON: > > - break; /* always try > to exclude */ > > > > CONSTRAINT_EXCLUSION_ON is no longer used, so should we remove it also > from guc parameters? > > Well, we haven't removed the "on" setting itself. Ah, I understand. > Okay, I've broken down those changes into separate patches, so that > cleanup hunks are not fixed with other complex changes. > > 0001 is now a patch to remove duplicate code from set_append_rel_size. > It combines multiple blocks that have the same body doing > set_dummy_rel_pathlist(). > > 0002 is the "overhaul inherited update/delete planning" > > 0003 is a cleanup patch that gets rid of some code that is rendered useless > due to 0002 (partitioned tables no longer use constraint exclusion) Thanks for doing these. > I think 0001 can be committed on its own. +1. In commit message: s/contradictory quals found/contradictory quals are found/ s/child excluded/child is excluded/ I think others in 0001 are ok. > 0002+0003 can be committed > together. > > 0004-0006 are the patches that were previously 0002-0004. I will do code review of v22 patches again and send notes as soon as possible. Yoshikazu Imai
