On Wed, 13 Feb 2019 at 19:36, Surafel Temesgen <surafel3...@gmail.com> wrote: > On Mon, Feb 11, 2019 at 10:20 AM David Rowley <david.row...@2ndquadrant.com> > wrote: >> >> Reviewing pg_dump-rows-per-insert-option-v14. >> >> Also, maybe one for Fabien (because he seems keen on keeping the >> --rows-per-insert validation code) >> >> strtol() returns a long. dump_inserts is an int, so on machines where >> sizeof(long) == 8 and sizeof(int) == 4 (most machines, these days) the >> validation is not bulletproof. This could lead to: >> >> $ pg_dump --rows-per-insert=2147483648 >> pg_dump: rows-per-insert must be a positive number > > > fixed
Thanks. I see you didn't touch the tests yet, so I'll set this back to waiting on author. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
