On Thu, Feb 07, 2019 at 11:56:18PM -0500, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > On Thu, Feb 07, 2019 at 10:12:05AM -0500, Tom Lane wrote: > >> I have no particular opinion on whether pgindent should be part of the > >> mix for imath, but I do strongly recommend setting up and documenting a > >> reproducible import process, as I did for src/timezone. > > > Good idea. I've modified the imath.c header comment to take the form of an > > import process; see attached imath1.29-pgedits-v2.patch. > > Maybe easier to keep the instructions in a separate README file?
Most imath.c patches have cause to update those lines, and patches to other files almost never do. Hence, I think hackers are more likely to find and update those lines in imath.c. I would choose a README if concerns weren't concentrated in one file. > (I don't see a need to put a PG copyright in this file, when the > mods from upstream are this small.) The tree has been inconsistent about that, which is okay. I was mimicking src/port/strlcpy.c. Others, e.g. src/port/crypt.c, haven't added a copyright.
