The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            tested, passed

Hello
Sorry for late response. I review latest patch version.

I didn't found any new behavior bugs.

reindex concurrenlty can be in deadlock with another reindex concurrently (or 
manual vacuum (maybe with wraparound autovacuum) or create index concurrently 
on same table). But i think this is not issue for this feature, two create 
index concurrently can be in deadlock too.

Just one small note for documentation:

> +Indexes:
> +    "idx" btree (col)
> +    "idx_cct" btree (col) INVALID

Second index should be idx_ccnew (or idx_ccold), right?

Code looks good for me.

regards, Sergei

Reply via email to