> On Fri, Feb 1, 2019 at 12:54 PM Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > > On 2019-Feb-01, Alvaro Herrera wrote: > > > On 2019-Feb-01, Alvaro Herrera wrote: > > > > ... and you're going to need "git format-patch -v19", because contrib > > doesn't build with 18. > > And that suggests that maybe we should keep the old names working, to > avoid breaking every extension out there that deals with ArrayRef, > though I'm not sure if after patches 0002 ff it'll be possible to keep > them working without changes.
Can you please point out for me what exactly doesn't build? I just tried to build contrib and ran all the tests, everything finished succesfully, which is also confirmed by bot [1]. > I think it's worth pointing out that "git format-patch -v" exists :-) Fortunately, I know. But yeah, no idea why I started to add a version number at the end of patch name :) [1]: https://travis-ci.org/postgresql-cfbot/postgresql/builds/487401077
