Michael Paquier <mich...@paquier.xyz> wrote: > Hi all, > > I just got a run with CFLAGS with the following options: > -Wunused-function -Wunused-variable -Wunused-const-variable > -Wno-unused-result -Wunused-parameter -Wunused-macros > > And while this generates a lot of noise for callbacks and depending on > the environment used, this is also pointing to things which could be > simplified:
This reminds me that I reported some unused arguments too: https://www.postgresql.org/message-id/6702.1473067599@localhost SnapBuildBuildSnapshot() was fixed in commit 6c2003f8a1b, but the other two are still there. -- Antonin Houska Cybertec Schönig & Schönig GmbH Gröhrmühlgasse 26, A-2700 Wiener Neustadt Web: https://www.cybertec-postgresql.com