On Tue, 29 Jan 2019 at 22:32, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > > On 2019/01/29 11:23, David Rowley wrote: > > 7. In set_inherit_target_rel_sizes() I still don't really like the way > > you're adjusting the EquivalenceClasses. Would it not be better to > > invent a function similar to adjust_appendrel_attrs(), or just use > > that function? > > OK, I added a function copy_eq_classes_for_child_root() that simply makes > a copy of eq_classes from the source root (deep-copying where applicable) > and returns the list.
hmm, but you've added a case for SpecialJoinInfo, is there a good reason not just to do the translation by just adding an EquivalenceClass case to adjust_appendrel_attrs_mutator() then just get rid of the new "replace" flag in add_child_rel_equivalences()? That way you'd also remove the churn in the couple of places you've had to modify the existing calls to add_child_rel_equivalences(). -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
