On Mon, Jan 28, 2019 at 10:18 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > In the pluggable-storage discussion, there was some talk of renaming > nodes/relation.h to avoid confusion with the new access/relation.h > header. I think this is a fine idea, not only because of that conflict > but because "relation.h" has never made a lot of sense as the file's > name.
+1. > After a bit of thought, I propose "pathnodes.h" as the new name. > That fits in with the other major headers in that directory > (primnodes.h, parsenodes.h, plannodes.h, execnodes.h), and it seems > like a reasonable summary of what's in it. Admittedly, Path nodes > as such are barely a third of the file's bulk; but I don't see any > equally pithy way to describe the rest of it, unless something like > planner_data.h, which is pretty unmelodious. Yeah, it's not perfect, but it's better than what we've got now. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
