Sorry, I left a garbage. At Mon, 28 Jan 2019 17:14:00 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20190128.171400.111796002.horiguchi.kyot...@lab.ntt.co.jp> > Hello, thank you for the new version. > > At Fri, 4 Jan 2019 00:25:57 +0100, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote in > <3f8a7a73-cebe-016f-49e3-853733f8b...@2ndquadrant.com> > > Updated patches for some merge conflicts > > 0001: Seems perfect to me. > > 0002: > > The test 54-56 of 001_ssltest.pl failed, which succeeded before > applying 0002. Seems to need to use another user.
"Seems to need to use another user." is useles leftover. > # Failed test 'pg_stat_ssl view without client certificate: no stderr' > # at t/001_ssltests.pl line 313. > # got: 'psql: SSL error: certificate verify failed > # FATAL: no pg_hba.conf entry for host "127.0.0.1", user "ssltestuser", > database "trustdb", SSL off > # ' > > If this is not specific to my environment, the connevcion string > at line 313 of 001_ssltests.pl needs sslrootcert setting (, which > is feeded to test_connect_ok/fails() via $connstr, not via > $common_connstr). > > 0003: Looks fine to me. > > regards. -- Kyotaro Horiguchi NTT Open Source Software Center
