On Wed, Jan 23, 2019 at 2:02 PM Andres Freund <and...@anarazel.de> wrote: > On 2019-01-23 09:55:22 +0900, Michael Paquier wrote: > > On Wed, Jan 23, 2019 at 01:37:41PM +1300, Thomas Munro wrote: > > > This could be really confusing for erm, future people reading a dot > > > matrix print-out of the source code? > > I think we should just rip them out. It's useless noise.
+1 IDENTIFICATION used to show magic CVS keywords, which was standard practice back then and probably useful. Now it's just a useless path, because Magnus removed the keywords 10 years ago in commit 9f2e2113869. The function name comments are similar, though less consistent so I'm too lazy to write a script to find one that is actually wrong (with which to trigger Andres's let's-delete-them-all response :-D). At least in the planner code, I think those might originally have been documentation of the names of the Lisp functions that each C function was ported from (for example in 4.2 source, sort_inner_and_outer's comment says "sort-inner-and-outer", a Lispy spelling). Bruce delispified some of them 20 years ago in commit 6724a507874. -- Thomas Munro http://www.enterprisedb.com
