On Thu, Jan 10, 2019 at 11:45 PM Andres Freund <and...@anarazel.de> wrote: > void (*relation_set_new_filenode) (Relation relation, > char persistence, > TransactionId *freezeXid, > MultiXactId *minmulti);
Honestly, I don't see the problem with that, really. But you could also use the style that is used in fdwapi.h, where we have a typedef for each callback first, and then the actual structure just declares a function pointer of each time. That saves a bit of horizontal space and might look a little nicer. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company