Andres Freund <and...@anarazel.de> writes:
> On 2019-01-09 14:44:24 -0500, Tom Lane wrote:
>> /* fast lookup only possible if original oid still assigned */
>> - if (id >= FirstGenbkiObjectId)
>> + if (id > fmgr_last_builtin_oid)
>> return NULL;
> An extern reference here will make the code a bit less efficient, but
> it's probably not worth generating a header with a define for it
> instead...
Yeah, also that would be significantly more fragile, in that it'd
be hard to be sure where that OID had propagated to when rebuilding.
We haven't chosen to make fmgr_nbuiltins a #define either, and I think
it's best to treat this the same way.
regards, tom lane
