On Sun, Dec 30, 2018 at 01:45:42AM -0500, Tom Lane wrote: > Hah, I was just about to work on that myself --- glad I didn't get > to it quite yet. A couple of thoughts: > > 1. Surely there's documentation about --disable-strong-random > to clean up too?
Oops, I forgot to grep on this one. Removed from my tree. > 2. I wonder whether it's worth adding this to port.h: > > extern bool pg_strong_random(void *buf, size_t len); > +/* pg_backend_random used to be a wrapper for pg_strong_random */ > +#define pg_backend_random pg_strong_random > > to prevent unnecessary breakage in extensions that might be depending > on pg_backend_random. Sure, that makes sense. Added. > 3. Didn't look, but the MSVC build code might need a tweak too > now that pg_strong_random.o is built-always rather than conditional? There is nothing needed here as pg_strong_random.c has always been included into @pgportfiles as we assumed that Windows would always have a random source. -- Michael
signature.asc
Description: PGP signature
