On Wed, Dec 26, 2018 at 05:55:36PM -0500, Tom Lane wrote: > It appears to me that the code is intentionally not worrying about > fsync failure, so it seems wrong for it to FATAL out if it's unable > to open the file to fsync it. And it surely shouldn't do so if the > file isn't there.
My point is a bit different though: it seems to me that we could just call BasicOpenFilePerm() and remove the stat() to do exactly the same things, simplifying the code. -- Michael
signature.asc
Description: PGP signature
