On 2018-Dec-26, Fabien COELHO wrote: > > > Copying & comparing nodes are updated. Should making, outing and reading > > > nodes also be updated? > > > > TransactionStmt isn't covered by the node serialization functions, so I > > didn't see anything to update. What did you have in mind? > > Sigh. I had in mind that the serialization feature would work with all > possible nodes, not just some of them… which seems quite naïve. The whole > make/copy/cmp/in/out functions depress me, all this verbose code should be > automatically generated from struct declarations. I'm pretty sure there are > hidden bugs in there.
There may well be, but keep in mind that the nodes that have out and read support are used in view declarations and such (stored rules); they are used pretty extensively. Nodes that cannot be part of stored rules don't need to have read support. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
