Hallo Michael,

Yeah, new rebased version attached.

Patch v8 applies cleanly, compiles, global & local make check are ok.

A few comments:

About added tests: the node is left running at the end of the script, which is not very clean. I'd suggest to either move the added checks before stopping, or to stop again at the end of the script, depending on the intention.

I'm wondering (possibly again) about the existing early exit if one block cannot be read on retry: the command should count this as a kind of bad block, proceed on checking other files, and obviously fail in the end, but having checked everything else and generated a report. I do not think that this condition warrants a full stop. ISTM that under rare race conditions (eg, an unlucky concurrent "drop database" or "drop table") this could happen when online, although I could not trigger one despite heavy testing, so I'm possibly mistaken.

--
Fabien.

Reply via email to