At Tue, 18 Dec 2018 18:48:25 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote in <20181218.184825.02619975.horiguchi.kyot...@lab.ntt.co.jp> > - Remove ""all" does not match "replication"". Instead "The "all" > keyword does not match replication connections." > - double-quoted database name is taken literally.
I found that in the documentation thanks to a notification off-list. And after some reconfirmation, what I want to fix is only a few lines of comment in pg_hba.conf.sample. -# database name, or a comma-separated list thereof. The "all" -# keyword does not match "replication". Access to replication -# must be enabled in a separate record (see example below). +# database name, or a comma-separated list thereof. The "all" keyword +# matches all databases. The "replication" keyword matches a physical +# replication connection request and it must be enabled in a separate +# record (see example below) regards. -- Kyotaro Horiguchi NTT Open Source Software Center
>From b270a38b3edc90a3f56cb07ea6fdd5a20140fd46 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp> Date: Fri, 21 Dec 2018 15:48:25 +0900 Subject: [PATCH] Clarify the comments about "all" and "replication" in pg_hba.conf.sample In the explanetory comments in the pg_hba.conf.sample file looks a bit misleading. Clarify the meaning of "all" and "replication" keywords by make database name distinctive from keywords. --- src/backend/libpq/pg_hba.conf.sample | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/backend/libpq/pg_hba.conf.sample b/src/backend/libpq/pg_hba.conf.sample index c853e36232..7c9c225afe 100644 --- a/src/backend/libpq/pg_hba.conf.sample +++ b/src/backend/libpq/pg_hba.conf.sample @@ -22,9 +22,10 @@ # plain TCP/IP socket. # # DATABASE can be "all", "sameuser", "samerole", "replication", a -# database name, or a comma-separated list thereof. The "all" -# keyword does not match "replication". Access to replication -# must be enabled in a separate record (see example below). +# database name, or a comma-separated list thereof. The "all" keyword +# matches all databases. The "replication" keyword matches a physical +# replication connection request and it must be enabled in a separate +# record (see example below). # # USER can be "all", a user name, a group name prefixed with "+", or a # comma-separated list thereof. In both the DATABASE and USER fields -- 2.16.3
