Hello.
At Mon, 17 Dec 2018 11:58:41 -0600, Justin Pryzby <pry...@telsasoft.com> wrote
in <20181217175841.gs13...@telsasoft.com>
> Our deployment script failed to notice dozens of commands failed in a
> transaction block and I only noticed due to keeping full logs and monitoring
> for error_severity>'LOG'. I would have thought that exit status would be
> nonzero had an error occured in an earlier script.
>
> The docs since PG9.6 say:
> https://www.postgresql.org/docs/9.6/app-psql.html
> |Exit Status
> |
> |psql returns 0 to the shell if it finished normally, 1 if a fatal error of
> its
> |own occurs (e.g. out of memory, file not found), 2 if the connection to the
> |server went bad and the session was not interactive, and 3 if an error
> occurred
> |in a script and the variable ON_ERROR_STOP was set.
>
> d5563d7df94488bf0ab52ac0678e8a07e5b8297e
> psql: Support multiple -c and -f options, and allow mixing them.
>
> If there's an error, it returns 1 (although that's not "a fatal error of its
> own").
>
> |[pryzbyj@database ~]$ psql ts -c foo 2>/dev/null ; echo $?
> |1
>
> But the error is "lost" if another script or -c runs without failing:
>
> |[pryzbyj@database ~]$ psql ts -txqc foo -c SELECT 2>/dev/null ; echo $?
> |0
As written in the documentation[1]:
> Because of this behavior, putting more than one SQL command in a
> single -c string often has unexpected results. It's better to use
> repeated -c commands or feed multiple commands to psql's standard
> input,
This seems saying that -c is equvalent to each line fed from
stdin or a line in a script.
The attached 0001 patch makes it clear in app-psql.html.
> Note, this works as expected:
>
> |[pryzbyj@database ~]$ psql ts -v ON_ERROR_STOP=1 -txqc foo -f /dev/null
> 2>/dev/null ; echo $?
> |1
The status should be 3, according to the documentation. Addition
to that, the current behavior looks inconsistent (if) considering
the equivalency between -c and a script line.
y.txt:
a)
foo;
select 1;
b)
select 1;
foo;
$ psql postgres -v ON_ERROR_STOP=0 -f ~/work/y.txt ; echo $?
$ psql postgres -v ON_ERROR_STOP=0 < ~/work/y.txt ; echo $?
All combinations return 0, and 3 when ON_ERROR_STOP=1.
But,
c) psql postgres -v ON_ERROR_STOP=0 -c foo -c 'select 1'; echo $?
d) psql postgres -v ON_ERROR_STOP=0 -c 'select 1' -c foo; echo $?
(c) returns 0 and (d) returns 1, but both return 1 when
ON_ERROR_STOP=1.
The attached second patch lets (c) and (d) behave the same as (a)
and (b).
Does it make sense?
regards.
[1]: https://www.postgresql.org/docs/11/app-psql.html
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 227c6014f3c50445ca1c46c4293085e6e635e91f Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp>
Date: Tue, 18 Dec 2018 16:44:28 +0900
Subject: [PATCH 1/2] Add description on a behavior of psql
psql's '-c command' is equivalent to a line fed from stdin or a line
written in a script. It is suggested in the documentation but not
explicitly described. Add a such description.
---
doc/src/sgml/ref/psql-ref.sgml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index 6c76cf2f00..4e94e8b6cf 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -147,6 +147,10 @@ psql <<EOF
SELECT * FROM foo;
EOF
</programlisting>
+
+ Every <option>-c</option> command is equivalent to a line in a
+ script. All the commands are executed ignoring command errors and psql
+ returns the exit status 0 unless ON_ERROR_STOP is set.
</para>
</listitem>
</varlistentry>
--
2.16.3
>From 449ee0b1003fed38ebd29fec6a19dec1cf12cf5e Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyot...@lab.ntt.co.jp>
Date: Tue, 18 Dec 2018 16:50:11 +0900
Subject: [PATCH 2/2] Unify psql's behavior on -c with scripts
Each -c command is equivalent to a line in a script, but they behaves
differently on failure. Fix it.
---
src/bin/psql/startup.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/bin/psql/startup.c b/src/bin/psql/startup.c
index e7536a8a06..fc50301fdc 100644
--- a/src/bin/psql/startup.c
+++ b/src/bin/psql/startup.c
@@ -347,7 +347,7 @@ main(int argc, char *argv[])
puts(cell->val);
successResult = SendQuery(cell->val)
- ? EXIT_SUCCESS : EXIT_FAILURE;
+ ? EXIT_SUCCESS : EXIT_USER;
}
else if (cell->action == ACT_SINGLE_SLASH)
{
@@ -368,7 +368,7 @@ main(int argc, char *argv[])
cond_stack,
NULL,
NULL) != PSQL_CMD_ERROR
- ? EXIT_SUCCESS : EXIT_FAILURE;
+ ? EXIT_SUCCESS : EXIT_USER;
psql_scan_destroy(scan_state);
conditional_stack_destroy(cond_stack);
@@ -383,7 +383,11 @@ main(int argc, char *argv[])
Assert(false);
}
- if (successResult != EXIT_SUCCESS && pset.on_error_stop)
+ /* EXIT_USER shuld be forgotten if ON_ERROR_STOP is not set */
+ if (successResult == EXIT_USER && !pset.on_error_stop)
+ successResult = EXIT_SUCCESS;
+
+ if (successResult != EXIT_SUCCESS)
break;
}
--
2.16.3
