On Thu, Dec 13, 2018 at 10:40:59PM +0300, Alexander Korotkov wrote: > On Thu, Dec 13, 2018 at 8:06 PM Andrey Borodin <x4...@yandex-team.ru> wrote: > > That's the same variable, one place is definition while other is potential > > misuse. > > Seems like these 2 lines [0] > > > > + if (BufferIsValid(lbuffer)) > > + UnlockReleaseBuffer(lbuffer); > > > > are superfluous: lbuffer is UnlockReleased earlier. > > Thanks to everybody for noticing! Speaking more generally backpatch > to 9.4 was completely wrong: there were multiple errors. It's my > oversight, I forget how much better our xlog system became since 9.4 > :) > > I've pushed bf0e5a73be fixing that.
I can confirm the compiler warning is now gone. Thanks. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
