Hello. At Wed, 5 Dec 2018 16:11:23 +0000, "Bossart, Nathan" <bossa...@amazon.com> wrote in <db47ebd7-7291-4c39-9f8f-be42e5193...@amazon.com> > The v4 patch looks good to me!
durable_unlnk has two modes of faiure. Failure to unlink and fsync. If once it fails at the fsync stage, subsequent durable_unlink calls for the same file always fail to unlink with ENOENT. If durable_unlink is intended to be called repeatedly on falure, perhaps it should return a different code for each failure so that the caller can indentify what to do next. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
