Hi, > Hello. > > At Thu, 29 Nov 2018 09:16:01 +0900 (JST), Tatsuo Ishii <is...@sraoss.co.jp> > wrote in <20181129.091601.830026250066724330.t-is...@sraoss.co.jp> >> >>> Hi, it makes sense to me. One can submit transaction again same as >> >>> other cases you mentioned. >> >>> >> >>> I didn't attach the patch but according to my simple experiment in >> >>> psql the output would become the following: >> >>> >> >>> FATAL: terminating connection due to idle-in-transaction timeout >> >>> HINT: In a moment you should be able to reconnect to the >> >>> database and repeat your command. >> >> >> >>Alternative HINT message would be something like: >> >> >> >>HINT: In a moment you should be able to reconnect to the >> >> database and restart your transaction. >> >> >> >>This could make the meaning of the error (transaction aborted) cleaner and >> >>might give >> >>a better suggestion to the user. >> > >> > Agreed. Changing "command" to "transaction" seems more accurate. People >> > might think >> > only the command they hit is not sent but transaction is still alive >> > though it's of course unnatural >> > that transaction is alive after connection is terminated. > > "session" seems more correct and covers both (and the other > instances below).
But "reconnect to the database" already implies "restarting session", no? If so, "...restart your session" would sound redundant to me. A native English speaker's comment is welcome. I may be wrong. >> > In this case you could change the comment issued by other errors mentioned >> > while you're at it. >> > >> > Regards, >> > Takeshi Ideriha >> >> I have added this to the next CF (2019-01). > > I found several more instances. > > "terminating connection due to conflict with recovery" (3 places) > "terminating connection due to administrator command" (1 place) > > regards. > > -- > Kyotaro Horiguchi > NTT Open Source Software Center >
