Daniel Gustafsson <dan...@yesql.se> writes:
> [ pg_upgrade_sockdir-v3.patch ]
BTW, I notice that cfbot doesn't like this now that Thomas is running it
with -Werror:
option.c: In function ‘parseCommandLine’:
option.c:265:8: error: ignoring return value of ‘getcwd’, declared with
attribute warn_unused_result [-Werror=unused-result]
getcwd(default_sockdir, MAXPGPATH);
^
cc1: all warnings being treated as errors
Failing to check a syscall's result isn't per project style even if
the tools would let you get away with it. Other places in that same
file do
if (!getcwd(cwd, MAXPGPATH))
pg_fatal("could not determine current directory\n");
regards, tom lane
