On 2018-Nov-21, Masahiko Sawada wrote: > I've looked into this issue and this happens on my environment (CentOS > 6.9 and gcob 4.4.7) as well. ISTM the cause would related to the > immediate shutdown mode we're using in test_recovery_standby. > Interestingly in my environment with the attached one-line patch the > coverage reports the branches parsing the individual recovery options > correctly. > > If my investigation is correct, all tests where use an immediate > shutdown might not counted by gcov.
Confirmed these results here, thanks for the research. I think we should change all calls of ->teardown_node to ->stop(), except the one in the END block, and look for places which are currently relying too much on END (i.e. add more ->stop() calls where needed). -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
